(DE-830) feat(dbt): add diversity metric in dbt #3655
Conversation
cdelabre-pass
force-pushed
the
DE-830/diversification-booking
branch
from
a0e7606 to
2de1162
Compare
| "type": "OFFER_SUBCATEGORY", | ||
| "score_multiplier": 10, | ||
| }, | ||
| {"entity": "venue_id", "type": "VENUE", "score_multiplier": 5}, |
There was a problem hiding this comment.
| {"entity": "venue_id", "type": "VENUE", "score_multiplier": 5}, | |
| { | |
| "entity": "venue_id", | |
| "type": "VENUE", | |
| "score_multiplier": 5, | |
| }, |
There was a problem hiding this comment.
Format par défaut du linter
| user_id, | ||
| booking_creation_date, | ||
| case | ||
| when booking_rank = 1 |
There was a problem hiding this comment.
l. 85/86 pas utile
-> Si booking_rank = 1 alors on aura toujours diversity_booking_entity_rank = 1 non ?
There was a problem hiding this comment.
Je n'ai pas trouvé la réponse à la question :
Est-ce que le premier incrément est de 0 point, 1 point ou de 25+10+20+5 points maintenant ?
Le case when était là pour ça et j'ai laissé cela en attendant.
There was a problem hiding this comment.
C'est bien 25+10+20+5! Donc "score_multiplier" fonctionne même pour l'initialisation il me semble
There was a problem hiding this comment.
Ok parfait j'enlève la règle alors :)
| row_number() over ( | ||
| partition by user_id, {{ entity.entity }} | ||
| order by booking_created_at | ||
| ) as diversity_booking_entity_rank |
| @@ -0,0 +1,8 @@ | |||
| select | |||
There was a problem hiding this comment.
Configurer la table incrémentale, partitionnée sur booking_id ?
There was a problem hiding this comment.
Les réservations pouvant être annulées, il me semble un peu plus compliqué de mettre la table en incrémentale. Par contre, nous pouvons tout à fait partitionner en fonction de l'usage.
| user_id, | ||
| booking_creation_date, | ||
| case | ||
| when booking_rank = 1 |
There was a problem hiding this comment.
C'est bien 25+10+20+5! Donc "score_multiplier" fonctionne même pour l'initialisation il me semble
|
DA PR
Describe your changes
Please include a summary of the changes:
Type of change
Checklist before requesting a review
PR title format (except for MEP)
There is a linter on the PR title format. Please respect the following format:
(ticket) type(topic): comment
ticket surrounded by parenthesis, with optionnaly a hyphen followed by one or more digits (e.g., -1234). The first part must be one of the following strings:
type :
The second part to specify the type of change one of the following :
topic within parenthesis: 1 word e.g., (dag)
comment: tell us your life
examples: